[Buildroot] [PATCH v3] faifa: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jun 8 17:16:48 UTC 2014


Dear Samuel Martin,

On Sun, 8 Jun 2014 19:08:32 +0200, Samuel Martin wrote:

> Just nit and late, but why do you need override the whole commands?
> All of this could have been set in the FAIFA_INSTALL_TARGET_OPT
> variable (respectively in FAIFA_INSTALL_STAGING_OPT):
> 
> FAIFA_INSTALL_TARGET_OPT = \
>     PREFIX=/usr \
>     STRIP=/bin/true \
>     DESTDIR=$(TARGET_DIR) \
>     install
> 
> Just nitpicking ;-)

True. I believe it doesn't make a lot of difference in terms of code
factorization, so to me, both solutions are almost equivalent.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list