[Buildroot] [PATCH] package infra: remove duplicates in dependencies list

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jun 8 16:51:50 UTC 2014


Dear Yann E. MORIN,

On Sun,  1 Jun 2014 12:28:54 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> 
> Currently, we just use what a package declares as its dependencies.
> 
> But some packages may declare the same depdency more than once. For
> example, php has two options to add SQL support: 'mysql' or 'mysqli',
> which are not exclusive. So, php.mk has mysql twice as a dependency.
> 
> Although that does not cause any grievance for make, we end up generating
> dependency graphs where this duplicate dependency is visible.
> 
> Add an intermediary variable which contains the $(sort)-ed list of the
> dependnecies, thus eliminating any duplicates.
> 
> This has the side effect of also sorting the list, which is probably
> good for reproducibility anyway.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list