[Buildroot] [PATCH v6 4/4] rpi-userland: cleanup *_CONF_OPT

Maxime Hadjinlian maxime.hadjinlian at gmail.com
Sun Jun 8 10:49:21 UTC 2014


Hi all,

Tested-by: "Maxime Hadjinlian" <maxime.hadjinlian at gmail.com>

On Thu, Jun 5, 2014 at 9:28 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Samuel, All,
>
> On 2014-06-05 01:04 +0200, Samuel Martin spake thusly:
>> This change reverts the commit 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf
>> because rpi-userland is correctly built whatever the value of the
>> BUILD_SHARED_LIBS CMake flags.
>>
>> The cset 5e3b1f31b3f82e3b163567f10d7131c9d649a2cf originally intends to
>> fix linkage/runtime failure in xbmc package because of missing flags in
>> xbmc LIBS env. var. This has been fixed in the previous patch.
>>
>> So, for rpi-userland package, BUILD_SHARED_LIBS does no longer need to
>> be forced to OFF, and can safely be driven by the CMake infrastructure.
>>
>> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
>> Cc: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>
> Tested-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> changes v5 -> v6:
>> - rebase
>>
>> changes v4 -> v5:
>> - rebase
>> - extend commit log (ThomasP)
>>
>> changes v3 -> v4:
>> - rebase
>>
>> changes v2 -> v3:
>> - new patch
>> ---
>>  package/rpi-userland/rpi-userland.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/rpi-userland/rpi-userland.mk b/package/rpi-userland/rpi-userland.mk
>> index 8b225ba..2de6b92 100644
>> --- a/package/rpi-userland/rpi-userland.mk
>> +++ b/package/rpi-userland/rpi-userland.mk
>> @@ -9,7 +9,7 @@ RPI_USERLAND_SITE = $(call github,raspberrypi,userland,$(RPI_USERLAND_VERSION))
>>  RPI_USERLAND_LICENSE = BSD-3c
>>  RPI_USERLAND_LICENSE_FILES = LICENCE
>>  RPI_USERLAND_INSTALL_STAGING = YES
>> -RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr -DBUILD_SHARED_LIBS=OFF
>> +RPI_USERLAND_CONF_OPT = -DVMCS_INSTALL_PREFIX=/usr
>>
>>  RPI_USERLAND_PROVIDES = libegl libgles libopenmax libopenvg
>>
>> --
>> 2.0.0
>>
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


More information about the buildroot mailing list