[Buildroot] [PATCH 5 of 7 v3] toolchain-external: change version from 'undefined' to 'virtual'

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jun 7 08:57:28 UTC 2014


Dear Thomas De Schampheleire,

On Fri, 06 Jun 2014 22:13:01 +0200, Thomas De Schampheleire wrote:
> The toolchain-external package displays the version 'undefined' in the build
> messages and the directory in output/build, which is not very nice.
> This patch sets the version to 'virtual', in analogy to the toolchain and
> toolchain-buildroot packages (which use the virtual-package infrastructure).
> 
> Although toolchain-external is not strictly a virtual package, since it uses
> the generic-package infrastructure, it can be considered as a virtual
> package in the sense that it does not have a fixed version or source (they
> depend on the selected external toolchain).
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

I'm sorry, but I continue to disagree. toolchain-external is definitely
*not* a virtual package. I've started using the
TOOLCHAIN_EXTERNAL_VERSION field for musl external toolchains, and I
will send a patch that use it for other toolchains as well.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list