[Buildroot] [PATCH 2/2] perf: Don't build backtrace for ARC

Anton Kolesov Anton.Kolesov at synopsys.com
Mon Jul 21 09:39:05 UTC 2014


Hi Thomas,

Call to backtrace() function fails for ARC, because for some reason unwinder from libgcc returns early. Thus usage of backtrace() should be disabled in perf explicitly, because build system only checks for existence of this call and since it is there it tries to use. However at runtime the output will not be the one expected: it will contain only several functions from the top of stack, instead of the complete backtrace.

> -----Original Message-----
> From: Thomas De Schampheleire [mailto:patrickdepinguin at gmail.com]
> Sent: 19 July 2014 00:24
> To: Anton Kolesov
> Cc: buildroot at busybox.net
> Subject: Re: [Buildroot] [PATCH 2/2] perf: Don't build backtrace for ARC
> 
> Anton,
> 
> Same for this mail, thanks.
> 
> On Fri, Jul 18, 2014 at 10:16 PM, Thomas De Schampheleire
> <patrickdepinguin at gmail.com> wrote:
> > Hi Mischa,
> >
> > On Tue, Jan 28, 2014 at 2:10 PM, Mischa Jonker
> > <Mischa.Jonker at synopsys.com> wrote:
> >> Signed-off-by: Mischa Jonker <mjonker at synopsys.com>
> >> ---
> >>  package/perf/perf.mk |    4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/package/perf/perf.mk b/package/perf/perf.mk
> >> index ffe18bc..5628ba5 100644
> >> --- a/package/perf/perf.mk
> >> +++ b/package/perf/perf.mk
> >> @@ -22,6 +22,10 @@ PERF_MAKE_FLAGS = \
> >>         WERROR=0 \
> >>         ASCIIDOC=
> >>
> >> +ifeq ($(BR2_arc),y)
> >> +       PERF_MAKE_FLAGS += NO_BACKTRACE=1
> >> +endif
> >> +
> >>  ifeq ($(BR2_PACKAGE_ELFUTILS),y)
> >>         PERF_DEPENDENCIES += elfutils
> >>  else
> >
> >
> > Could you give more details as to why this is needed?
> > I see no autobuild failures for perf on ARC, so what is the problem here?
> > If this patch is still needed, I think the commit message should be
> > expanded for that.
> >
> > Thanks,
> > Thomas

Anton




More information about the buildroot mailing list