[Buildroot] [PATCH] python: fix termios build for xtensa

Max Filippov jcmvbkbc at gmail.com
Sat Jul 19 00:06:30 UTC 2014


On Fri, Jul 18, 2014 at 5:30 PM, Baruch Siach <baruch at tkos.co.il> wrote:
> Hi Max,
>
> On Fri, Jul 18, 2014 at 03:42:43PM +0400, Max Filippov wrote:
>> On Fri, Jul 18, 2014 at 7:32 AM, Baruch Siach <baruch at tkos.co.il> wrote:
>> > The xtensa ioctls.h header references struct serial_multiport_struct that is
>> > not defined in this header or included headers. ioctls.h also references
>> > tty_struct that is not exported to userspace at all. Add a patch fixing these
>> > issues.
>> >
>> > This is only a workaround as the real problem should be fixed in the kernel
>> > (by removing all struct references like all other archs). But since we support
>> > older kernel versions we'll have to carry this patch for some time.
>> >
>> > Fixes:
>> > http://autobuild.buildroot.net/results/12b/12b5612828d7f1fc7d1f69fc01341d5a6e628db5/
>> >
>> > Cc: Max Filippov <jcmvbkbc at gmail.com>
>> > Signed-off-by: Baruch Siach <baruch at tkos.co.il>
>> > ---
>> >  .../python-015-serial-ioctl-workaround.patch       | 23 ++++++++++++++++++++++
>> >  1 file changed, 23 insertions(+)
>> >  create mode 100644 package/python/python-015-serial-ioctl-workaround.patch
>>
>> Thank you, Baruch.
>> I'll send corresponding linux patches. I definitely saw this issue
>> some time ago,
>> but I couldn't find any trace of that ):
>
> You mean commit b973b4c91be8f (xtensa: fix TIOCGSERIAL and TIOCSSERIAL
> definitions)? It solved part of the problem.

Oh, right, other similar symbols.

> It seems most other architectures migrated to asm-generic/ioctls.h.

This would change existing IOCTL codes, so I don't think we can do it.

-- 
Thanks.
-- Max


More information about the buildroot mailing list