[Buildroot] [PATCH 2/5] support/download: properly use temp files
Yann E. MORIN
yann.morin.1998 at free.fr
Tue Jul 8 21:52:55 UTC 2014
Arnout, All,
On 2014-07-08 18:42 +0200, Arnout Vandecappelle spake thusly:
> On 07/07/14 23:38, Yann E. MORIN wrote:
> > On 2014-07-07 08:11 +0200, Arnout Vandecappelle spake thusly:
[--SNIP--]
> >> Not that it makes a real difference, but I think that 'cp' is a more natural
> >> way to do this.
> >
> > I am not sure how cp handles copying over an existing file. I'll
> > check...
>
> It does. It only unlinks if open(O_TRUNC) fails. (Checked with strace for
> coreutils and my reading the source for busybox.)
I'll rework the entire series to take your and Jacmet's comments in
consideration.
Thanks for the reviews! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list