[Buildroot] [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr

Baruch Siach baruch at tkos.co.il
Thu Jul 3 16:32:58 UTC 2014


Since we are only need to know whether the compiler runs successfully, and
stderr is empty for the success case, there is no need to redirect stderr to
/dev/null. Moreover, stderr output of the failing case reveals valuable
information on the real failure reason.

Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Signed-off-by: Baruch Siach <baruch at tkos.co.il>
---
 toolchain/helpers.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index c85968054012..8eb71efc19eb 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -298,7 +298,7 @@ check_arm_abi = \
 		echo "External toolchain uses the unsuported OABI" ; \
 		exit 1 ; \
 	fi ; \
-	if ! echo 'int main(void) {}' | $${__CROSS_CC} -x c -o /dev/null - 2>/dev/null; then \
+	if ! echo 'int main(void) {}' | $${__CROSS_CC} -x c -o /dev/null - ; then \
 		abistr_$(BR2_ARM_EABI)='EABI'; \
 		abistr_$(BR2_ARM_EABIHF)='EABIhf'; \
 		echo "Incorrect ABI setting: $${abistr_y} selected, but toolchain is incompatible"; \
-- 
2.0.0



More information about the buildroot mailing list