[Buildroot] [Patch v3 1/1] systemd: rework network/tty units installation

[Eric Le Bihan]

On Wed, Jul 02, 2014 at 10:15:17PM +0200, Thomas Petazzoni wrote:
> Dear Eric Le Bihan,
>
> On Wed, 2 Jul 2014 19:49:00 +0200, Eric Le Bihan wrote:
>
> > Looking back, converting the fixup of getty service from an post installation
> > hook to a service installation was not a good idea, after all.
> >
> > $(PKG)_INSTALL_INIT_SYSTEMD is performed before installing the package itself
> > in the target directory via $(PKG)_INSTALL_TARGET_CMDS. So the fixup will fail
> > trying to delete a file that has not been installed yet... (D'Oh! I should
> > have cleaned my build directory...).
> >
> > I will send a patch reverting this part.
>
> Hum, right, I don't know if a fixup of a file belongs to
> <pkg>_INSTALL_INIT_SYSTEMD. But the fact that <pkg>_INSTALL_INIT_<foo>
> gets executed *before* the package is installed to the target looks a
> bit weird. Is there a reason for that?

>From package/pkg-generic.mk at line 227:

	$(if $(BR2_INIT_SYSTEMD),\
		$($(PKG)_INSTALL_INIT_SYSTEMD))
	$(if $(BR2_INIT_SYSV)$(BR2_INIT_BUSYBOX),\
		$($(PKG)_INSTALL_INIT_SYSV))
	+$($(PKG)_INSTALL_TARGET_CMDS)
	$(foreach hook,$($(PKG)_POST_INSTALL_TARGET_HOOKS),$(call $(hook))$(sep))

I see no harm in swapping these lines...

Best regards,
ELB