[Buildroot] [PATCH 2/2] Update MySQL client package

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sun, 19 Jan 2014 12:51:24 +0100, Yann E. MORIN wrote:

> >         depends on BR2_USE_MMU
> >         depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> > +
> > +if BR2_PACKAGE_MYSQL
> > +
> > +config BR2_PACKAGE_MYSQL_CLIENT
> > +        bool "MySQL client"
> > +
> > +config BR2_PACKAGE_MYSQL_CLIENT_SERVER
> > +       bool "MySQL server"
> > +
> > +endif
> 
> What if neither the client nor the server is selected? Does that make
> sense? If not, then always build the client (as we currently do), and
> make the server an option (as you did in your previous patch).

I would suggest:

config BR2_PACKAGE_MYSQL
	bool "mysql"
	select BR2_PACKAGE_MYSQL_CLIENT if !BR2_PACKAGE_MYSQL_SERVER

if BR2_PACKAGE_MYSQL

config BR2_PACKAGE_MYSQL_CLIENT
	bool "client"

config BR2_PACKAGE_MYSQL_SERVER
	bool "server"

endif

This way, we guarantee that at least either the client or the server
are enabled.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com