[Buildroot] [PATCH 1/2] rings: add the version major variable
Jerzy Grzegorek
jerzy.grzegorek at trzebnica.net
Tue Jan 28 22:40:11 UTC 2014
Hi Thomas,
> Dear Jerzy Grzegorek,
>
> On Tue, 14 Jan 2014 11:30:57 +0100, Jerzy Grzegorek wrote:
>> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek at trzebnica.net>
>> ---
>> package/rings/rings.mk | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/rings/rings.mk b/package/rings/rings.mk
>> index d052f5d..2876162 100644
>> --- a/package/rings/rings.mk
>> +++ b/package/rings/rings.mk
>> @@ -4,7 +4,8 @@
>> #
>> ################################################################################
>>
>> -RINGS_VERSION = 1.3.0-1
>> +RINGS_VERSION_MAJOR = 1.3.0
>> +RINGS_VERSION = $(RINGS_VERSION_MAJOR)-1
>> RINGS_SUBDIR = rings-v_1_3_0
>> RINGS_LICENSE = MIT
> While I agree with <foo>_VERSION_MAJOR, when <foo>_VERSION_MAJOR is
> used in more than one place, I don't necessarily think it is needed
> when it is used in only one place, <foo>_VERSION.
>
> Thomas
I think, you didn't read my second patch:
[PATCH 2/2] package: unification of use $(subst
[._-],[._-],$(<PKG>_VERSION)) macro
Regards,
Jerzy
More information about the buildroot
mailing list