[Buildroot] [PATCH] tcpreplay: cross-compile with tcpdump support

[Peter Korsgaard]

>>>>> "Martin" == Martin Bark <martin at barkynet.com> writes:

Hi,

 >> > +ifeq ($(BR2_PACKAGE_TCPDUMP),y)
 >> > +TCPREPLAY_CONF_ENV += ac_cv_path_tcpdump_path=/usr/sbin/tcpdump
 >> 
 >> The problem here is that the configure script checks if /usr/bin/tcpdump
 >> (on the build machine) is executable, and otherwise errors out - So this
 >> breaks if you try to build it on a machine without tcpdump.

 > I think the patch is actually OK.  Looking at the configure script
 > when ac_cv_path_tcpdump_path is set it does not check if the
 > executable exists.  It only checks when using the --with-tcpdump
 > option.

 > I tested the patch and choose tcpdump and tcpreplay with no
 > /usr/sbin/tcpdump on the host.  The code builds and I see in the
 > configure output the lines

 > checking for tcpdump... (cached) /usr/sbin/tcpdump

 > and

 > tcpdump binary path:        /usr/sbin/tcpdump

 > So i think this patch will work.

Ups, you're right - Sorry.

Committed patch, thanks.

-- 
Bye, Peter Korsgaard