[Buildroot] [PATCH 2/2] Prefer 'printf' over 'echo -e' (for portability)

Bjørn Forsman bjorn.forsman at gmail.com
Tue Jan 21 18:07:11 UTC 2014


On 21 January 2014 09:40, Peter Korsgaard <jacmet at uclibc.org> wrote:
>>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin at gmail.com> writes:
>
> Hi,
>
>  > I find it very strange that we're mixing printf and echo in this same
>  > file. I would suggest to either use echo only, or printf only. The
>  > statement
>  > echo -e '\nblaat'
>  > is functionally equivalent to:
>  > echo
>  > echo blaat
>
>  > Your point about printf being more portable is valid, and has been
>  > raised in the past by Yann (I believe) as well.
>  > This means that moving to printf iso echo makes sense, but then this
>  > patch should be reworked as to fix the entire file.
>
>  > Note that this is just my opinion, I can't speak for the entire community.
>
> Yes, I agree. I would also like to see the same style used everywhere in
> the file.

I agree. I'll fix it and send new patches.


More information about the buildroot mailing list