[Buildroot] [PATCH 4/5] system: default to empty issue/hostname for custom skeleton

[Yann E. MORIN]

Peter, All,

On 2014-01-09 21:32 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:
> 
>  > From: Sagaert Johan <sagaert.johan at skynet.be>
>  > A custom skeleton may include /etc/issue and/or /etc/hostname, in
>  > which case we do not want to override them.
> 
>  > But those files could also be missing from the custom skeleton, or
>  > the user may want to override their content.
> 
>  > Make the current default value for isue and hostname depend on the
>  > generic skeleton, and default to empty for a custom skeleton.
> 
>  > Signed-off-by: Sagaert Johan <sagaert.johan at skynet.be>
>  > [yann.morin.1998 at free.fr: change from hiding it behind SKELETON_DEFAULT
>  >     to use conditional default values; move below the skeleton choice;
>  >     improve help entries]
>  > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> 
> Do we really need to add this extra complexity? A custom skeleton is not
> recommended (and in any case an advanced option), and the fix for
> people not wanting /etc/issues / hostname overwritten is very easy, they
> can just set it to the empty string.
> 
> What do others say?

Note that this is part of the patchwork-cleanup effort #5 by Thomas DS:
    http://lists.busybox.net/pipermail/buildroot/2014-January/086071.html

The original patch was:
    http://patchwork.ozlabs.org/patch/211644/

Which is now superseded by this very patch we're discussing.

I don't much care about it either. Sagaert Johan, maybe you could expose
your arguments in favour of this change?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'