[Buildroot] [PATCH 1/2] Remove some absolute paths

Bjørn Forsman bjorn.forsman at gmail.com
Wed Jan 1 20:24:22 UTC 2014


Hi Thomas,

On 1 January 2014 18:13, Thomas De Schampheleire
<patrickdepinguin at gmail.com> wrote:
[...]
> There is at least one reason why using variables to refer to tools in
> makefiles makes sense: in make, any variable can be overruled on the
> command-line. So you can call 'make SED=/my/own/sed' without any
> special rules in the makefile itself. This is not possible if you
> directly use 'sed' (or whatever tool).

Good point.

I don't know if your remark was specific to my patch or just in
general, but I'd like to point out this patch changes a shell script,
not a makefile. Although a bit more troublesome than your make
example, this injects custom 'sed' in any language:
PATH=/my/sed/bin:$PATH some_tool.

I consider this patch a minor "fix". Adding variables for commands
(everywhere) in Buildroot is a different thing that should be in a
different patch set.

Please let me know if there is anything in *this* patch that I need to
change to get it merged.

Best regards,
Bjørn Forsman


More information about the buildroot mailing list