[Buildroot] [RFC, PATCH 3/8] package/ncurses: Allow building wide char support
Jeremy Kerr
jk at ozlabs.org
Fri Feb 28 02:53:19 UTC 2014
Hi Thomas,
>> + bool "enable wide char support"
>> + depends on BR2_PACKAGE_NCURSES
>
> dependency not needed since you're inside a if BR2_PACKAGE_NCURSES.
>
> I believe this option most likely depends on BR2_USE_WCHAR.
>
> Also, maybe name the option BR2_PACKAGE_NCURSES_WCHAR, to match the
> BR2_USE_WCHAR name we're already using in Buildroot to talk about wide
> char support.
OK, makes sense, fixed.
> Pffiou, that's a lot of things. Maybe we could refactor this a little
> with the target installation to do something a bit smarter like:
>
> NCURSES_LIBS-y += libncurses
> NCURSES_LIBS-$(BR2_PACKAGE_NCURSES_TARGET_MENU) += libmenu
> NCURSES_LIBS-$(BR2_PACKAGE_NCURSES_TARGET_PANEL) += libpanel
> NCURSES_LIBS-$(BR2_PACKAGE_NCURSES_TARGET_FORM) += libform
>
> and then use $(NCURSES_LIBS-y) and some loops in target installation
> and in a staging post installation hook to create the appropriate
> symbolic links.
That looks much better. I'll split this change into two stages: one to
implement NCURSES_LIBS-y, and one to add BR2_PACKAGE_NCURSES_WCHAR.
Cheers,
jeremy
More information about the buildroot
mailing list