[Buildroot] [git commit] ncftp: clarify the NCFTP_RUN_AUTOCONF hook.

Peter Korsgaard peter at korsgaard.com
Tue Feb 25 21:11:18 UTC 2014


commit: http://git.buildroot.net/buildroot/commit/?id=5263aa681ab46bd072b7e8a77780afe3ff39c339
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

When I saw this patch it took me a while to figure out how/why it worked,
so let's make life easier for the eventual version bumper to understand
what's going on here.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
 package/ncftp/ncftp.mk |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
index 841c82b..6ab3934 100644
--- a/package/ncftp/ncftp.mk
+++ b/package/ncftp/ncftp.mk
@@ -13,10 +13,13 @@ NCFTP_LICENSE_FILES = doc/LICENSE.txt
 
 NCFTP_DEPENDENCIES = host-autoconf
 
+# The bundled configure script is generated by autoconf 2.13 and doesn't
+# detect cross-compilation correctly. Therefore, we have to regenerate it.
+# We need to pass -I because of the non-standard m4 directory name, and
+# none of the other autotools are used, so the below is the easiest.
 define NCFTP_RUN_AUTOCONF
        (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
 endef
-
 NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
 
 ifeq ($(BR2_PACKAGE_NCFTP_GET),y)


More information about the buildroot mailing list