[Buildroot] [PATCH 4 of 7] packages: remove support for documentation on target
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Feb 5 13:34:11 UTC 2014
Dear Thomas De Schampheleire,
On Wed, 5 Feb 2014 14:28:48 +0100, Thomas De Schampheleire wrote:
> Looking at this file, I don't know if your suggestion makes sense.
> Here is part of the original file:
>
> -----------------------------------
> KMOD_VERSION = 16
> KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz
> KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod/
> KMOD_INSTALL_STAGING = YES
> KMOD_DEPENDENCIES = host-pkgconf
> HOST_KMOD_DEPENDENCIES = host-pkgconf
>
> # license info for libkmod only, conditionally add more below
> KMOD_LICENSE = LGPLv2.1+
> KMOD_LICENSE_FILES = libkmod/COPYING
>
> # static linking not supported, see
> # https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=b7016153ec8
> KMOD_CONF_OPT = --disable-static --enable-shared
>
> # manpages not installed and needs xsltproc
> HOST_KMOD_CONF_OPT = --disable-manpages
> KMOD_CONF_OPT += --disable-manpages
>
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> KMOD_DEPENDENCIES += zlib
> KMOD_CONF_OPT += --with-zlib
> endif
>
> ifeq ($(BR2_PACKAGE_XZ),y)
> KMOD_DEPENDENCIES += xz
> KMOD_CONF_OPT += --with-xz
> endif
> ------------------------------------
>
> I can certainly put the two manpage-related lines above the static
> linking, but this is just a move in the file, right?
You're right, I agree my suggestion doesn't make much sense. Just keep
your patch as it was, it is good.
Sorry for the noise :/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list