[Buildroot] [PATCH v2 1/7] Adding ding-libs

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Dec 31 17:03:14 UTC 2014


Dear Gregory Dymarek,

On Fri, 12 Dec 2014 15:42:41 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002 at gmail.com>
> ---
>  package/Config.in                |  1 +
>  package/ding-libs/Config.in      |  9 +++++++++
>  package/ding-libs/ding-libs.hash |  1 +
>  package/ding-libs/ding-libs.mk   | 17 +++++++++++++++++
>  4 files changed, 28 insertions(+)
>  create mode 100644 package/ding-libs/Config.in
>  create mode 100644 package/ding-libs/ding-libs.hash
>  create mode 100644 package/ding-libs/ding-libs.mk

Thanks, applied, after doing again a fairly significant amount of fixes:

    [Thomas:
     - Remove unneeded comment in Config.in
     - Remove select if libiconv, not needed
     - Add dependency on wchar, needed when we depend on gettext
     - Improve Config.in help text
     - Fix the format of the hash file to make it actually useful
     - Fix the comment header in the .mk file
     - Remove useless commented line in .mk file
     - Fixup license information: it's not under GPLv3, but under LGPLv3+
       (library) and GPLv3+ (test programs)
     - Add host-pkgconf to the dependencies, remove libiconv from the
       dependencies.
     - Add a comment to explain why autoreconf is needed.
     - Remove usage of $(MAKE1) that does look necessary.]

See
http://git.buildroot.net/buildroot/commit/?id=3af1d306bdc4144e243e453221a7ab5a49b14e56
for the final commit.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list