[Buildroot] [PATCH v2] legacy: update the BR2_PREFER_STATIC_LIB option
Peter Korsgaard
peter at korsgaard.com
Sun Dec 14 16:50:47 UTC 2014
>>>>> "Samuel" == Samuel Martin <s.martin49 at gmail.com> writes:
> Since the refactoring of the type of libraries in the target filesystem,
> these options belong to a choice, and the default is "shared only".
> The former option BR2_PREFER_STATIC_LIB has been moved in the legacy
> menu, and only selects the BR2_STATIC_LIBS ("static only") option.
> However, because BR2_STATIC_LIBS belongs to a choice, when
> BR2_PREFER_STATIC_LIB is selected, it does not affect the choice.
> So, existing Buildroot configurations, which have BR2_PREFER_STATIC_LIB
> set, will silently end with BR2_SHARED_LIBS ("shared only") enabled.
> So, the backward compatibility is not kept.
> Besides, the legacy BR2_PREFER_STATIC_LIB option does not select
> BR2_LEGACY, so the user is not notified of this legacy option, and the
> build silently continues with some undesired changes.
> This patch removes the inefficient BR2_STATIC_LIBS selection, correctly
> selects the BR2_LEGACY option and extend the help message so the user
> can easily know how to update his/her Buildroot configuration.
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
> Cc: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
> changes v1->v2:
> - fix typos in commit log
> - update A/R/T tags
Committed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list