[Buildroot] [PATCH 1/1] screen: add support for 256 colors

[Vicente Olivert Riera]

Dear Thierry Bultel,

On 12/09/2014 03:26 PM, Thierry Bultel wrote:

>  define SCREEN_INSTALL_SCREENRC
> -	$(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc
> +	if [ ! -f $(TARGET_DIR)/etc/screenrc ]; then \
> +		$(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc; \
> +	fi
>  endef
>  
>  SCREEN_POST_INSTALL_TARGET_HOOKS += SCREEN_INSTALL_SCREENRC

This part is not related with adding support for 256 colors, so, why
don't you send a separate patch for it? Or at least, state in your
commit message you are fixing a little issue with the 'screenrc' file
installation. But I would say that a separate patch would be better.

Best regards,
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com