[Buildroot] [PATCH branch/next] pinentry: bump version to 0.9.0

Vicente Olivert Riera Vincent.Riera at imgtec.com
Mon Dec 8 16:10:40 UTC 2014


Dear Thomas Petazzoni,

On 12/08/2014 03:52 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
> 
> On Mon, 8 Dec 2014 15:48:01 +0000, Vicente Olivert Riera wrote:
> 
>> it was a problem when building pinentry-qt4, which needs to have support
>> for Qt accessibility. Qt accessibility is enabled by default on Qt, but
>> we disable it in Buildroot by passing "-no-accessibility" to the
>> configure script. I don't know why we do that. There is no comment in
>> the .mk file.
> 
> Simply because many people probably don't need it, and therefore we
> disabled it by default, waiting for someone who needs it to add an
> option for it.
> 
>> When you fix that, you face another problem which is not related with us
>> (Buildroot) but a mistake (that's my opinion) made by the person who
>> released the pinentry tarball. I have reported the issue upstream and
>> written a patch for Buildroot in the meantime.
>>
>> While I was working on all of this, I noticed that the options we had
>> for disablen pinentry-gtk1 and pinentry-qt3 where no longer needed since
>> those options don't exist anymore in the configure script, and the
>> directories gtk and qt don't exist either when you unpack the tarball.
>>
>> Path sent:
>>   http://patchwork.ozlabs.org/patch/418743/
> 
> The accessibility part should be made optional.

I can send a patch to pinentry to make the accessibility part optional.
Do you prefer I mark my current patch as rejected and do another one
including the patch for making the accessibility part optional instead
of modifying packages/qt/qt.mk?

Cheers,
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com


More information about the buildroot mailing list