[Buildroot] [PATCH v3] Add a defconfig for MIPS Creator CI20
Vicente Olivert Riera
Vincent.Riera at imgtec.com
Mon Dec 1 14:28:33 UTC 2014
On 12/01/2014 02:13 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:
>
> >> Exactly: We do some minimal config tweaks to ensure you have a working
> >> setup. See the logic in linux/linux.mk (LINUX_CONFIGURE_CMDS).
>
> > I have seen that file and I found this snippet:
>
> > $(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),,
> > $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> > $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
>
> > It adds those two options to the kernel config only if
> > BR2_ROOTFS_DEVICE_CREATION_STATIC has been selected. I think this is
> > also needed for BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS. I'm going
> > to test it right now to make sure.
>
> No, notice the 2x ",". The syntax of the $(if ) construct is $(if
> <condition>,<command-of-nonempty>,<command-if-empty>), so this is done
> for everything but the static /dev case.
>
> > Also, could you tell me why that if statement has two comma (,,) instead
> > of one? What's the difference with having only one comma?
>
> See above or:
>
> https://www.gnu.org/software/make/manual/html_node/Conditional-Functions.html#index-if
Facepalm.
Thanks Peter, I will send a patch to remove the MDEV option in the
ci20_defconfig.
Cheers,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
More information about the buildroot
mailing list