[Buildroot] [PATCH v2 1/1] package/xscreensaver: fix linking with intl
Romain Naour
romain.naour at openwide.fr
Wed Aug 27 21:52:58 UTC 2014
Hi Thomas,
Le 26/08/2014 09:23, Thomas Petazzoni a écrit :
> Dear Romain Naour,
>
> On Tue, 26 Aug 2014 01:13:06 +0200, Romain Naour wrote:
>
>> + select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
>
> Have you verified if it's really BR2_NEEDS_GETTEXT or
> BR2_NEEDS_GETTEXT_IF_LOCALE that should be used?
>
gettext package is always selected with xscreensaver when BR2_NEEDS_GETTEXT is
set due to dependencies on libgtk2 and libglib2.
This is libglib2 that select gettext package when BR2_NEEDS_GETTEXT is set.
But, It seems that xscreensaver can live without gettext by looking at
utils/xscreensaver-intl.h.
So, it's seems correct to select gettext package when
BR2_NEEDS_GETTEXT_IF_LOCALE is set but the build fail with the following link error:
xscreensaver.o: In function `main':
undefined reference to `libintl_bindtextdomain'
undefined reference to `libintl_textdomain'
That why I added BR2_NEEDS_GETTEXT...
Ok, I just found a patch that fix this issue in version 5.28.
Please see v3.
Thanks for your review !
Best regards
Romain
More information about the buildroot
mailing list