[Buildroot] [PATCH 0 of 5 v4 for 2014.08] manual-text generation improvements

Samuel Martin s.martin49 at gmail.com
Sat Aug 16 11:00:15 UTC 2014


On Sat, Aug 16, 2014 at 12:15 PM, Thomas De Schampheleire
<patrickdepinguin at gmail.com> wrote:
> On Sat, Aug 16, 2014 at 9:35 AM, Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com> wrote:
>> Dear Thomas De Schampheleire,
>>
>> On Fri, 15 Aug 2014 15:40:33 +0200, Thomas De Schampheleire wrote:
>>
>>> Thomas De Schampheleire (5)
>>>   Makefile: unconditionally include pkg-utils.mk
>>>   gendoc infra: use $(pkgname) instead of explicitly passing 'manual'
>>>   gendoc infra: add support for asciidoc configuration files
>>>   manual-text: make sure URLs are displayed if a link text was provided
>>>   manual-text: hide image representations
>>
>> Nice, you've added the list of patches to the cover letter :-)
>
> Yes :-)
>
>>
>> I've applied the patch series, thanks to you, and to Yann and Samuel
>> for testing/reviewing.
>>
>> Related to this patch series, here are a few things I noted:
>>
>>  * When building the PDF and txt versions of the manual, I get one
>>    warning:
>>
>>    a2x: WARNING: --destination-dir option is only applicable to HTML based outputs
>>
>>    It seems to be harmless as the result is really located in the right
>>    place (output/docs), but I found it worth mentioning.
>
> Yes, I see the same. We could pass format specific options to avoid
> passing -D for non-html formats. Not sure whether it's worth the
> effort, I will have a look.

I've noticed this too, but have not found a proper way to suppress it.

>
>>
>>  * Also, here the PDF version of the manual doesn't build:
>>
>>    a2x: ERROR: "dblatex" -t pdf -p "/etc/asciidoc/dblatex/asciidoc-dblatex.xsl" -s "/etc/asciidoc/dblatex/asciidoc-dblatex.sty" -P latex.output.revhistory=0  "/home/thomas/projets/buildroot/output/docs/manual/manual.xml" returned non-zero exit status 1

Few shortcomings:
- the generated appendix tables are only included in the html manual
(when running: make manual-clean manual). It seems these files are not
regenerated after the 'rm -rf $$(@D)/.build' :-/
- the above error seems related to these generated appendix tables,
because when they don't exits, the pdf manual generation succeeds.

This makes me think about refactoring the manual.mk to be closer to
the package ones, i.e. having it build directory under $(0)/build,
maybe inheriting from generic-package...
Anyway, this is just wild ideas; for the upcoming release there is
this pdf issue to fix.

>
> I will have a look at this too, but I may need your help here.
> Could you run the same command manually? It should show more output...
>
> Thanks,
> Thomas
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Regards,

-- 
Samuel


More information about the buildroot mailing list