[Buildroot] [PATCH V2] gdb: allow building on AArch64 systems

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Aug 7 10:00:31 UTC 2014


Dear Alex Bennée,

On Thu, 07 Aug 2014 10:46:47 +0100, Alex Bennée wrote:

> > On Wed,  6 Aug 2014 09:42:14 +0100, Alex Bennée wrote:
> >> gdb has had AArch64 support since 7.6 which is now the default minimum
> >> version of GDB in the tree. Older versions are now legacy.
> >> 
> >> Signed-off-by: Alex Bennée <alex.bennee at linaro.org>
> >
> > Applied, thanks!
> 
> How are you applying the patches? I'm curious because while my local
> patch shows up in the log with:
> 
> commit 0b729ce2baa9903e7d3520196f9fff16cdff24fa
> Author: Alex Bennée <alex.bennee at linaro.org>
> 
> The one in upstream is:
> 
> commit 4372449a4f8e16f763c7d5a0c125ca015a7cbef6
> Author: alex.bennee at linaro.org <alex.bennee at linaro.org>
> 
> I'd usually assume utf-8 shenanigans tripping something up but I see the
> repo does have names with more accents than mine ;-)

We're using pwclient, which downloads the patch from patchwork and
applies it with "git am".

There's basically no chance for your local commit used to generate the
patch to have the same SHA1 as the commit integrated in the official
repository. Your commit applies on commit A, but it ends up applied on
top of commit B. And since the SHA1 of the parent commit is part of
what defines the next commit and therefore it's SHA1, there's no chance
for your commit to have the same SHA1 in the official repo as in your
local repo with the workflow we have.

SHA1 would be preserved if we were taking pull requests and merging
those pull requests without rebasing them. But basically, by using "git
am", we're rebasing all patches on top of the latest master when
applying them, which changes their SHA1.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list