[Buildroot] [RFC PATCH 0/2] gitorious helper

Thomas De Schampheleire patrickdepinguin at gmail.com
Tue Apr 29 05:18:08 UTC 2014


Alexandre Belloni <alexandre.belloni at free-electrons.com> schreef:
>Hi,
>
>On 10/01/2014 at 16:35:10 +0800, Thomas Petazzoni wrote :
>> > 2. accept the fact that the URL cannot be changed, but modify the wget
>> > download helper so that it can rename the file after download
>> > (clarifying the list of files in dl/)
>> > 
>> > In the first alternative, the gitorious helper can be a one-liner just
>> > as for github, and the .mk files only need to specify FOO_SITE.
>> > In the second alternative, we need to set two variables FOO_SITE and
>> > FOO_SOURCE. In your current patchset, you have done this with one
>> > helper that sets both variables. As a result, the usage compared to
>> > the github helper is fundamentally different.
>> > For github:
>> > FOO_SITE = $(call github,username,package,$(FOO_VERSION))
>> > while for gitorious:
>> > $(call gitorious,username,package,$(FOO_VERSION)
>> > 
>> > I don't like this difference, and suggest two alternatives:
>> > A. split the helper in two, so that:
>> > FOO_SITE = $(call gitorious-site,username,package,$(FOO_VERSION))
>> > FOO_SOURCE = $(call gitorious-version,username,package,$(FOO_VERSION))
>> 
>> I very much prefer this solution. I don't really like the helper that
>> magically defines FOO_SITE and FOO_VERSION.
>> 
>
>After discussing quickly with Thomas, we feel that we can drop it as
>this would not really help with readability.

Readability wasn't the only reason such helpers were introduced. For github, the download urls changed a few times, and having it coded in only one place made changing this much easier.
So if that us the only reason I prefer to keep this patch. I'm willing to adopt it by the way...

Best regards,
Thomas



More information about the buildroot mailing list