[Buildroot] [PATCH 9/9] boot/syslinux: add an option to install an MBR blob

[Arnout Vandecappelle]

On 28/04/14 21:52, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2014-04-28 18:23 +0200, Arnout Vandecappelle spake thusly:
>               ^^^^^
> 
> I don't know why, but I only received it now (delivered to my server
> at 21:03:30 +0200) ? ... :-/

 That's because I read and reply to my buildroot mail on the train,
offline. It then sits on my mail server until I turn on my laptop again
in the evening (or sometimes the following day...).

> 
>> On 25/04/14 00:30, Yann E. MORIN wrote:
>>> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>>>
>>> This MBR blob will look for an active partition, and boot the bootcode
>>> present in that partition. This can be used to boot an extlinux-prepared
>>> partition.
>>>
>>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>>> Cc: Thomas Lundquist <lists at zelow.no>
>>> Cc: Frank Hunleth <fhunleth at troodon-software.com>
>>> ---
>>>  boot/syslinux/Config.in   | 13 ++++++++++++-
>>>  boot/syslinux/syslinux.mk |  1 +
>>>  2 files changed, 13 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/boot/syslinux/Config.in b/boot/syslinux/Config.in
>>> index d556c55..7d4dd08 100644
>>> --- a/boot/syslinux/Config.in
>>> +++ b/boot/syslinux/Config.in
>>> @@ -15,7 +15,7 @@ choice
>>>  
>>>  config BR2_TARGET_SYSLINUX_LEGACY_BIOS
>>>  	bool "bios (legacy)"
>>> -	select BR2_TARGET_SYSLINUX_ISOLINUX if !BR2_TARGET_SYSLINUX_PXELINUX
>>> +	select BR2_TARGET_SYSLINUX_ISOLINUX if !BR2_TARGET_SYSLINUX_HAS_BIOS_IMG
>>
>>  Hm, I don't really like this very much. Adding complexity like this for
>> behaviour which is not even really perfect...
> 
> Since you replied to my other reply (he!), I think switching all of this
> to a all-choice makes this comment moot, right? :-)

 Indeed, as I said in that reply :-)



 Regards,
 Arnout

> 
>>> +config BR2_TARGET_SYSLINUX_MBR
>>> +	bool "mbr"
>>> +	select BR2_TARGET_SYSLINUX_HAS_BIOS_IMG
>>> +	help
>>> +	  Install the legacy BIOS 'mbr' image, to boot off a
>>
>>  See my comment in 4/9 about "legacy".
> 
> Ditto, already covered.
> 
>>  BTW, while you're at it, perhaps you can add options for syslinux (=fat)
>> and extlinux?
> 
> For extlinux, please see my previous answer.
> 
> I'll have a look at syslinux, but I believe it is the same as extlinux.
> 
> Regards,
> Yann E. MORIN.
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F