[Buildroot] [PATCH] grub2: add configuration options for grub config files

Dima Zavin dmitriyz at google.com
Sun Apr 20 16:05:48 UTC 2014


Sounds great, thanks!

--Dima
On Apr 20, 2014 8:52 AM, "Thomas Petazzoni" <
thomas.petazzoni at free-electrons.com> wrote:

> Dear Dima Zavin,
>
> On Fri,  4 Apr 2014 01:32:17 -0700, Dima Zavin wrote:
> > Add an option for embedding a config file directly in grub as
> > well as an option to provide a custom grub.cfg file through
> > a defconfig.
> >
> > Signed-off-by: Dima Zavin <dmitriyz at google.com>
> > ---
> >  boot/grub2/Config.in | 12 ++++++++++++
> >  boot/grub2/grub2.mk  |  8 +++++++-
> >  2 files changed, 19 insertions(+), 1 deletion(-)
>
> I've applied your patch, but:
>
>  * I've removed the BR2_TARGET_GRUB2_CONFIG option, because the same
>    thing can be achieved using a post-build script or a rootfs overlay.
>    We don't have options in each and every package that can use a
>    custom configuration, so I don't really see a reason to have this
>    for Grub2 specifically.
>
>  * I've reworded the Config.in help for the built-in configuration file
>    option.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140420/5b3510c8/attachment.html>


More information about the buildroot mailing list