[Buildroot] [PATCH v11] xbmc: new package

[Bernd Kuhls]

"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote in
news:1395875160-14253-1-git-send-email-yann.morin.1998 at free.fr: 

> +ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
> +XBMC_DEPENDENCIES += rpi-userland
> +XBMC_CONF_OPT += --with-platform=raspberry-pi --enable-player=omxplayer
> +XBMC_CONF_ENV +=
> INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \ +    
> -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" +endif

Hi,

while testing Gotham beta3 using configs/raspberrypi_defconfig I stumbled 
across this part of xbmc.mk. The defconfig does not enable the BR2
_PACKAGE_RPI_USERLAND package, so xbmc is configured without its special 
raspberry platform option. Changing the above if-clause to check for package 
BR2_PACKAGE_RPI_FIRMWARE, which is used in raspberrypi_defconfig, seems to 
work better, at least Gotham beta3 is compiled without errors.

I have to add that I do not own a Raspberry system, this was the first time 
ever I compiled code for it ;) What do you think about this patch?

diff --git a/package/xbmc/xbmc.mk b/package/xbmc/xbmc.mk
index 9169698..e1885fc 100644
--- a/package/xbmc/xbmc.mk
+++ b/package/xbmc/xbmc.mk
@@ -43,7 +43,7 @@ XBMC_CONF_OPT +=  \
        --disable-rsxs \
        --enable-optimizations

-ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE),y)
 XBMC_DEPENDENCIES += rpi-userland
 XBMC_CONF_OPT += --with-platform=raspberry-pi --enable-player=omxplayer
 XBMC_CONF_ENV += INCLUDES="-I
$(STAGING_DIR)/usr/include/interface/vcos/pthreads \

Regards, Bernd