[Buildroot] [PATCH v2] xscreensaver: new package

Peter Korsgaard jacmet at uclibc.org
Thu Sep 26 13:48:44 UTC 2013


>>>>> "spdawson" == spdawson  <spdawson at gmail.com> writes:

 spdawson> From: Simon Dawson <spdawson at gmail.com>
 spdawson> Signed-off-by: Simon Dawson <spdawson at gmail.com>

 spdawson> +++ b/package/xscreensaver/xscreensaver.mk
 spdawson> @@ -0,0 +1,21 @@
 spdawson> +################################################################################
 spdawson> +#
 spdawson> +# xscreensaver
 spdawson> +#
 spdawson> +################################################################################
 spdawson> +
 spdawson> +XSCREENSAVER_VERSION = 5.22
 spdawson> +XSCREENSAVER_SITE = http://www.jwz.org/xscreensaver
 spdawson> +
 spdawson> +# N.B. GPLv2+ code (in the hacks/glx subdirectory) is not currently built.
 spdawson> +XSCREENSAVER_LICENSE = MIT-like GPLv2+
 spdawson> +XSCREENSAVER_LICENSE_FILES = hacks/screenhack.h hacks/glx/chessmodels.h

You could argue that we shouldn't add the glx / GPLv2+ stuff here if we
aren't using them - But ok, like this we won't forget to add them if we
ever enable the glx support.


 spdawson> +
 spdawson> +XSCREENSAVER_DEPENDENCIES = jpeg libglade libgtk2 xlib_libX11 xlib_libXt \
 spdawson> +	$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 spdawson> +
 spdawson> +XSCREENSAVER_CONF_OPT += LIBS=-lintl

We should only add -lintl if gettext is enabled, otherwise we'll end up
with linker errors, and we normally pass LIBS= in the configure
environment, not as an option.

Here I had to explicitly point --includedir / --libdir to staging,
otherwise it would end up adding -I/usr/include and -L/usr/lib causing
all kinds of issues.

Committed with these changes, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list