[Buildroot] [PATCH 1/1] package: remove the trailing slash sign from the URL address
Arnout Vandecappelle
arnout at mind.be
Wed Sep 18 22:48:39 UTC 2013
On 18/09/13 17:34, Thomas De Schampheleire wrote:
> Hi Jerzy,
>
> Op 18-sep.-2013 17:25 schreef "Jerzy Grzegorek"
> <jerzy.grzegorek at trzebnica.net <mailto:jerzy.grzegorek at trzebnica.net>>
> het volgende:
> >
> > Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek at trzebnica.net
> <mailto:jerzy.grzegorek at trzebnica.net>>
> > ---
>
> Could you clarify why this is desirable? Note that urls with our without
> trailing slash are not identical: the web server needs to properly
> support this. For example, the autobuild website does not properly do it
> (something very annoying ;) )
>
> So, with a change like this, every changed url needs to be tested.
Well, with the trailing slash is stripped by pkg-generic.mk:
$(call DOWNLOAD,$($(PKG)_SITE:/=)/$($(PKG)_SOURCE))
So functionally it doesn't matter if the / is there or not.
I'm pretty much in favour of removing the /.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
More information about the buildroot
mailing list