[Buildroot] [PATCH 1/1] package: udev is now provided by systemd or eudev.

[Arnout Vandecappelle]

On 18/09/13 17:56, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
>
> On Wed, 18 Sep 2013 08:57:46 +0200, Arnout Vandecappelle wrote:
>
>>> No, I disagree with this. There are some other packages (currently
>>> udisks and network-manager) that explicitly need the udev extras. So I
>>> believe it's useful for these packages to be able to 'select
>>> BR2_PACKAGE_UDEV_ALL_EXTRAS'. Of course, they could 'select
>>> BR2_PACKAGE_LIBGLIB2' and depend on udev, but this means that they have
>>> internal knowledge of the fact that udev needs libglib2 to enable 'all
>>> extras', an internal knowledge that could very well be broken if
>>> tomorrow udev needs another dependency to build its 'all extras' things.
>>>
>>> So, the BR2_PACKAGE_(E)UDEV_ALL_EXTRAS option should remain in place, I
>>> believe.
>>
>>    I didn't write the network-manager and udisks integration, but I think
>> that they _actually_ need gudev, not some vague "all extras". And for
>> gudev it's pretty darn obvious that there is a relation with libglib2. In
>> fact, both of them should probably select libglib2 directly, because they
>> are based on gobject classes.
>
> Right, that's one way of seeing things, indeed. It sounds a bit
> convoluted to me, though. When a package A needs a specific feature
> from package B (such as gudev), I believe it makes sense for package B
> to provide a sub-option that package A can select, rather than package
> A having intimate knowledge of the dependencies needed by package B to
> enable whatever feature package A needs to have from package B.

  Makes sense, but we probably already have tons of these already. If 
gudev would have been added in the normal way instead of introducing the 
all_extras option, then the implementors of network-manager and udisks 
wouldn't even have noticed that udev had to be compiled in a specific 
way: since these tools already select libglib2, udev would have been 
compiled with gudev support.

  Really, the all-extras is historical accident because a long time ago 
udev's configure had an EXTRAS=... option in its build commands.

  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F