[Buildroot] [PATCH v3] apply-patches.sh: detect missing patches
Peter Korsgaard
jacmet at sunsite.dk
Mon Sep 16 07:11:49 UTC 2013
>>>>> "Peter" == Peter Korsgaard <jacmet at uclibc.org> writes:
>>>>> "Ralph" == Ralph Siemsen <ralphs at netwinder.org> writes:
Ralph> The "patch" command returns an error code only if patches fail
Ralph> to apply. Therefore the pipleline "cat <patchfile> | patch ..."
Ralph> does not fail, even if <patchfile> is missing. Fix this by
Ralph> adding an explicit check for patch file existence.
Ralph> Based on feedback from buildroot mailing list, also change the
Ralph> existing check for unsupported patch format into a fatal error.
Ralph> ---
Ralph> v1. original
Ralph> v2. error on unsupported patch formats
Ralph> v3. explicit exit calls
Peter> Committed, thanks.
Peter> You forgot to add your 'Signed-off-by' on the patch. I've added it for
Peter> you, hopefully that is OK?
It unfortunately for the projects using tarballs containing patches,
E.G:
http://autobuild.buildroot.net/results/3d5/3d5f2c960ff2cc2003c9cc68d3a5a48009f5602f/build-end.log
The tarball contains:
debian/
debian/control
debian/postinst
debian/postinst.nfs
debian/source/
debian/source/options
debian/source/format
debian/shlibs
debian/prerm.nfs
debian/rules
debian/postrm
debian/shlibs.nfslock
debian/patches/
debian/patches/07-493462-dotlockfile.c.patch
debian/patches/series
debian/patches/04-505851-remove-debug-code.patch
debian/patches/02-COPYRIGHT.patch
debian/patches/06-493462-dotlockfile.1.patch
debian/patches/09-562937-make-ar-overwrittable.patch
debian/changelog
So a bunch of non-patch files. I guess our best option is to degrade the
"Unsupported format" check to a warning again?
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list