[Buildroot] [PATCH] gcc-initial: Add host-elf2flt dependency when BR2_PACKAGE_HOST_ELF2FLT=y

[Axel Lin]

2013/9/11 Gustavo Zacarias <gustavo at zacarias.com.ar>:
> On 09/04/2013 01:19 PM, Thomas Petazzoni wrote:
>
>> Dear Axel Lin,
>>
>> On Wed, 04 Sep 2013 23:18:35 +0800, Axel Lin wrote:
>>> It's needed for some uClibc combination, link-flat.so which uses elf2flt
>>> pulls in libgcc according to uclibc/Makerules (used in uclibc/libc/Makefile.in).
>>> Thus pull it in for gcc-initial.
>>>
>>> This also ensures elf2flt is ready when BR2_PACKAGE_HOST_ELF2FLT=y before
>>> building other packages.
>>>
>>> Signed-off-by: Axel Lin <axel.lin at ingics.com>
>>
>> Reviewed-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>
> Actually pulling in host-elf2flt should depend on BINFMT_FLAT rather
> than the package being selected, as per the patch i've just sent.

Either looks ok to me. (I don't see the difference here.)

Probably not directly related to this topic, but I have a question about
the dependency between BR2_BINFMT_FLAT & BR2_PACKAGE_HOST_ELF2FLT.

Why not just make BR2_PACKAGE_HOST_ELF2FLT depend on BR2_BINFMT_FLAT
rather than "depends on BR2_arm || BR2_bfin || BR2_sh || BR2_sparc"?

I'm not familiar with sparc.
But according to current dependency setting, it's not possible to select
BR2_BINFMT_FLAT for sparc but it's possible to select BR2_PACKAGE_HOST_ELF2FLT
for sparc.

Regards,
Axel