[Buildroot] [PATCH 5/5] util-linux: Fix cross-compile for host-util-linux when ncurses not selected

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Oct 30 21:18:59 UTC 2013


Dear Olivier Schonken,

On Wed, 30 Oct 2013 22:20:12 +0200, Olivier Schonken wrote:

> +ifeq ($(BR2_PACKAGE_NCURSES),y)
> +HOST_UTIL_LINUX_DEPENDENCIES += ncurses
> +else
> +HOST_UTIL_LINUX_CONF_OPT += --without-ncurses
> +endif

This cannot be correct. BR2_PACKAGE_NCURSES tells whether ncurses is
enabled for the target, but you're using that to decide how to
configure the host util-linux.

Since I believe we most likely don't need ncurses support at all in the
host util-linux, we can unconditionally add a --without-ncurses to
HOST_UTIL_LINUX_CONF_OPT. Could you resend an updated patch that
implements this?

Also, it would be good if you could improve the commit log by adding
the relevant piece of build log containing the util-linux configure
error.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list