[Buildroot] [PATCH 2/2] qt5base: add an option to build and install examples

Ezequiel García ezequiel at vanguardiasur.com.ar
Mon Oct 14 17:02:08 UTC 2013


On 14 October 2013 13:42, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Ezequiel García,
>
> On Mon, 14 Oct 2013 11:11:14 -0300, Ezequiel García wrote:
>
>> > +ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
>> > +QT5BASE_CONFIGURE_OPTS += -make examples -compile-examples
>> > +else
>> > +QT5BASE_CONFIGURE_OPTS += -nomake examples
>> > +endif
>> > +
>>
>> Any reason why this is not with the rest of the options
>> and using the simpler:
>>
>> QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_EXAMPLES), \
>>         -make examples -compile-examples, \
>>         -nomake examples)
>>
>> ?
>
> I agree with your first point (it should be with the other configure
> option), but I disagree with your second point. The choice Fatih has
> made is the one we make everywhere in Buildroot whenever the "if"
> becomes multiline. I'd very much prefer Fatih to keep its original
> proposal.
>
> We use $(if ...) only when it can be done like this:
>
> FOO_SOMETHING = $(if $(BR2_BLEH),foo,bar)
>
> when it becomes more complicated than that, we use ifeq ... else ...
> endif blocks on several lines.
>

Sure, no objections on my side.

Fatih: if you re-submit this, you can add my:

Tested-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>

It's great to see the Qt5 support is moving forward!
-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar


More information about the buildroot mailing list