[Buildroot] [PATCH] libxmlrpc: new package
Alvaro Gamez
alvaro.gamez at hazent.com
Wed Oct 9 12:08:29 UTC 2013
Hi!
2013/10/9 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> It would be good to use a number in the patch file names, such as:
>
> libxmlrpc-01-<something>.patch
> libxmlrpc-02-<somethingelse>.patch
>
In this case, the order doesn't matter, but will do anyway
> +#############################################################
Those lines should have 80 #
>
Done.
> One empty line between the header and the first variable.
>
And done.
> Can you add LIBXMLRPC_LICENSE and LIBXMLRPC_LICENSE_FILES ?
>
Done, although it's not perfect, there are three different licenses, two of
them bsd like... it's a bit confusing.
> > +define LIBXMLRPC_REMOVE_DEVFILE
> > + $(RM) $(TARGET_DIR)/usr/bin/xmlrpc-c-config
> > +endef
>
> Hum, maybe this should use the <pkg>_CONFIG_SCRIPTS mechanism instead
> (if xmlrpc-c-config is a shell script).
>
Yes, it is much cleaner now.
I'm sending the new patch right now
--
Álvaro Gámez Machado
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131009/0ecef81e/attachment-0001.html>
More information about the buildroot
mailing list