[Buildroot] [PATCHv3 03/20] package: add a <pkg>_EXTRA_DOWNLOADS variable

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Oct 8 21:55:37 UTC 2013


Dear Peter Korsgaard,

On Tue, 08 Oct 2013 23:32:16 +0200, Peter Korsgaard wrote:

>  Thomas> In order to achieve this, we add a <pkg>_EXTRA_DOWNLOADS variable,
>  Thomas> which allows a package to list other stuff it would like to see
>  Thomas> downloaded, but that are otherwise not used by the package
>  Thomas> infrastructure itself: it is up to the package to do it by itself.
> 
> I think it should be possible to support a space seperated list of
> sources in <pkg>_SOURCE, similar to how we do it for <pkg>_PATCH without
> breaking backwards compatibility, but I won't delay this series because
> of it - So committed, thanks.

This has been discussed in a prior version of this patch set. The
problem is that <pkg>_SOURCE is not only about downloading, but also
about extracting.

So, what would <pkg>_SOURCE do? Download all the files listed, but
extract only the first one? This seems like a weird semantic. I think I
prefer the following clear semantic:

 <pkg>_SOURCE is one file, that gets downloaded and then extracted into
 the source directory of the package.

 <pkg>_PATCH is a list of files or URLs, that get downloaded and apply
 as patches into the source directory

 <pkg>_EXTRA_DOWNLOADS is a list of files that get downloaded, and
 nothing else. The package is responsible for doing something with them.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list