[Buildroot] [PATCH v2] Add new package espeak, a speech synthesizer software

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Oct 8 12:16:02 UTC 2013


Dear arnaud.aujon at gmail.com,

On Tue,  8 Oct 2013 12:28:09 +0200, arnaud.aujon at gmail.com wrote:
> From: Arnaud Aujon <arnaud.aujon at gmail.com>
> 
> Signed-off-by: Arnaud Aujon <arnaud.aujon at gmail.com>

Thanks, it looks better since the patch is no longer wrapped, but other
than that, you haven't taken into account any of the comments I made in
the review of the first version.

Have you seen the comments I made at
http://lists.busybox.net/pipermail/buildroot/2013-October/079804.html ?
Look at the entire e-mail, my answer was spread in the different parts
of the e-mail, depending on what the comment was referring to.

Also, your previous commit title was better, it should be just:

	espeak: new package

Thanks

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list