[Buildroot] Some legal-info observations/problems

[Thomas De Schampheleire]

Hi Peter,

On Wed, Oct 2, 2013 at 4:22 PM, Peter Korsgaard <jacmet at uclibc.org> wrote:
>>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin at gmail.com> writes:
>
>
>  Thomas> 2. suppose FOO_LICENSE_FILES = subdir/COPYING, then the manifest also
>  Thomas> contains the string 'subdir/COPYING'. However, the license is copied
>  Thomas> into a flat structure output/legal-info/licenses/foo/, so I think that
>  Thomas> the manifest should no longer mention the 'subdir'.
>  Thomas> Of course, this may contradict with the needs of licenses.txt (the
>  Thomas> flat representation of all licenses) that does not suffer from the
>  Thomas> subdir problem.
>
>  Thomas> 3. partially related to point 2: if a package has multiple license
>  Thomas> files with the same name but in subdirectories, e.g. a/COPYING and
>  Thomas> b/COPYING, the copying of the license will copy both files on top of
>  Thomas> each other. This is the case for xenomai-forge (not yet in buildroot),
>  Thomas> which is the new strategy for xenomai [1]. I have brought up this
>  Thomas> issue with the developers [2], but maybe there is something else we
>  Thomas> can do.
>
> Do you still see this after 31aa4264d8839d0?
>
> Author: Peter Korsgaard <jacmet at sunsite.dk>
> Date:   Wed Jun 5 10:52:18 2013 +0200
>
>     pkg-utils.mk: legal-license-file: handle multiple license files with same name
>
>     Some packages (kmod, e2fsprogs, ..) contain multiple (different) license
>     files with the same file name, but in different directories.
>
>     These are currently all copied to the same filename in
>     output/legal-info/licenses/<pkg>, overwriting everything but the last file.
>
>     Fix it by recreating the same directory structure under legal-info.
>
>     Signed-off-by: Peter Korsgaard <jacmet at sunsite.dk>
>

Ah, I am testing this with 2013.05, so I don't have this yet. Thanks
for the pointer, I will take this commit along.
It should solve points 2 and 3 of my list.

Thanks,
Thomas