[Buildroot] [PATCH 1/1] omniorb: add COS Naming Service

[Matthew Weber]

Peter Korsgaard <jacmet at gmail.com> wrote on 11/12/2013 04:24:10 PM:

> From: Peter Korsgaard <jacmet at uclibc.org>
> To: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> Cc: Matt Weber <mlweber1 at rockwellcollins.com>, buildroot at busybox.net
> Date: 11/12/2013 04:24 PM
> Subject: Re: [PATCH 1/1] omniorb: add COS Naming Service
> Sent by: Peter Korsgaard <jacmet at gmail.com>
> 
> >>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin at gmail.com> 
writes:
> 
> Hi,
> 
> >> +if BR2_PACKAGE_OMNIORB
> >> +
> >> +config BR2_PACKAGE_OMNIORB_WITH_SERVICES
> >> +        bool "COS Naming Service"
> >> +        default y
> >> +        help
> >> +          omniORB COS Naming Service
> >> +endif
> >> +
> >> comment "omniORB needs a toolchain w/ C++"
> >> depends on !BR2_INSTALL_LIBSTDCPP
> 
> > I think it makes more sense to keep this comment close to the config
> > option it applies to, thus moving the new cos option below it.  I know
> > that many packages do not follow this, but I'm planning on fixing
> > that...
> 
> Careful, kconfig needs sub options to be directly under the main option,
> otherwise they don't get indented correctly in menuconfig, so your
> options are either:

Thanks for the clarification, I was wondering if that was needed.
I just tested moving it above and that seems to be more readable then 
below.

Thanks,
Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/bcb5fdd1/attachment.html>