[Buildroot] [PATCH] system/device-table: do not set /home/default stgid
Yann E. MORIN
yann.morin.1998 at free.fr
Sat May 25 20:37:11 UTC 2013
All,
On 2013-05-25 22:33 +0200, Yann E. MORIN spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>
> Currently, /home/default is mode 2755 which means it is setgid.
> Since /home/default is not group-writable, it is useless.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>
> ---
> AFAICS, there is no reason that /home/default be setgid.
> However, I have not audited all packages to check whether one
> would require that.
> ---
> system/device_table.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/device_table.txt b/system/device_table.txt
> index 421728b..43c0cfa 100644
> --- a/system/device_table.txt
> +++ b/system/device_table.txt
> @@ -9,7 +9,7 @@
> /dev d 755 0 0 - - - - -
> /tmp d 1777 0 0 - - - - -
> /etc d 755 0 0 - - - - -
> -/home/default d 2755 1000 1000 - - - - -
> +/home/default d 755 1000 1000 - - - - -
> /var/www d 755 33 33 - - - - -
> /etc/shadow f 600 0 0 - - - - -
> /etc/passwd f 644 0 0 - - - - -
I think this should got in -next, not master. If it should go at all.
Any reason for this setgid bit on a group-unwritable directory in the
first place?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list