[Buildroot] [PATCH] Standardisation of $(BUILD)/.root name
Arnout Vandecappelle
arnout at mind.be
Tue May 14 21:52:58 UTC 2013
On 14/05/13 17:07, Thomas Petazzoni wrote:
> Dear Jérôme Pouiller,
>
> On Tue, 14 May 2013 16:30:50 +0200, Jérôme Pouiller wrote:
>
>> -$(BUILD_DIR)/.root:
>> +$(STAMP_DIR)/skeleton-target-installed:
>> mkdir -p $(TARGET_DIR)
>> rsync -a \
>> --exclude .empty --exclude .svn --exclude .git \
>> --exclude .hg --exclude=CVS --exclude '*~' \
>> $(TARGET_SKELETON)/ $(TARGET_DIR)/
>> cp support/misc/target-dir-warning.txt $(TARGET_DIR_WARNING_FILE)
>> + mkdir -p $(STAMP_DIR)
>> touch $@
>
> I'm generally ok with the idea, but I don't like this mkdir. There is
> already a mkdir that creates the stamp file directory, in the main
> Makefile.
I don't have an issue with a few redundant mkdir -p calls.
I would like to see a $(Q) in front of it though - but then it should
be in front of the rest as well, and with a $(MESSAGE) call.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
More information about the buildroot
mailing list