[Buildroot] [PATCH] Standardisation of $(BUILD)/.root name

Jérôme Pouiller jezz at sysmic.org
Tue May 14 15:27:39 UTC 2013


On Tuesday 14 May 2013 17:07:21 Thomas Petazzoni wrote:
> Dear Jérôme Pouiller,
> 
> On Tue, 14 May 2013 16:30:50 +0200, Jérôme Pouiller wrote:
> > -$(BUILD_DIR)/.root:
> > 
> > +$(STAMP_DIR)/skeleton-target-installed:
> >  	mkdir -p $(TARGET_DIR)
> >  	rsync -a \
> >  	
> >  		--exclude .empty --exclude .svn --exclude .git \
> >  		--exclude .hg --exclude=CVS --exclude '*~' \
> >  		$(TARGET_SKELETON)/ $(TARGET_DIR)/
> >  	
> >  	cp support/misc/target-dir-warning.txt $(TARGET_DIR_WARNING_FILE)
> > 
> > +	mkdir -p $(STAMP_DIR)
> > 
> >  	touch $@
> 
> I'm generally ok with the idea, but I don't like this mkdir. There is
> already a mkdir that creates the stamp file directory, in the main
> Makefile.
I also dislike this mkdir. My problem is to be sure $(STAMP_DIR) is created 
before $(STAMP_DIR)/skeleton-target-installed. 

I can change order of dependencies in dirs target but this solution is too 
fragile.

I cannot just add a dependency between $(STAMP_DIR)/skeleton-target-installed 
and  $(STAMP_DIR).

I can add a stampfile for $(STAMP_DIR) but it looks a little complicated. 

I can also use an intermediate phony target (like dirs target) but it also 
looks complicated.


Any better idea?

-- 
Jérôme Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr


More information about the buildroot mailing list