[Buildroot] [PATCH 1/4] directfb: bumping version to 1.6.3
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Mar 21 19:13:52 UTC 2013
Dear Carsten Schoenert,
On Thu, 21 Mar 2013 19:06:13 +0100, Carsten Schoenert wrote:
> > How it _should_ be is that as many configure options as possible are
> > specified explicitly in the .mk file. In particular, any configure option
> > that is set to the non-default value in the .mk file, should also be set
> > explicitly to the default value.
>
> You mean for example
> --enable-svg build SVG image provider [default=yes]
> should be set by default to 'yes' and so on for the other 'default=yes'
> options?
> The options with default=auto should will be automaticly detected by
> configure and mostly it isn't useful to explicitly deactivating them
> because that breaks the binarys so leaving them.
No, I think Arnout means that we should leave as few options
"automatically" detected as possible.
For example, we really like to have:
ifeq ($(BR2_PACKAGE_FOO_FEATURE_BAR),y)
FOO_CONF_OPT += --enable-bar
else
FOO_CONF_OPT += --disable-bar
endif
and for all options that are not explicitly --enable-<bleh> somewhere,
have a global:
FOO_CONF_OPT += \
--disable-<bleh> \
--disable-<blah>
this avoids the configure script from automatically detecting things on
the host machine that we don't want it to detect.
> > But of course, a lot of that is not the case now, because the rule is
> > not strictly enforced. Anything you fix during the version bump is nice
> > to have, but you're not obliged to fix it if you don't know how to (and
> > we expect you to have tested the change, so that means trying out a
> > number of different configurations...).
>
> Yes I can't test all variations so thats why I ask here how to do it
> best. I'm working with a toolchain for a ARMv6 platform on a settopbox
> there we need directfb so I test mostly of my work on this settopbox.
We have autobuilders that test a big number of random configurations,
so you definitely don't have to test all combinations.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list