[Buildroot] [PATCH 1/3] sunxi-tools: new host package

Carlo Caione carlo.caione at gmail.com
Fri Mar 8 10:07:50 UTC 2013


On Fri, Mar 8, 2013 at 10:37 AM, Samuel Martin <s.martin49 at gmail.com> wrote:
> Hi Carlo,
[cut]
>> +config BR2_PACKAGE_HOST_SUNXI_TOOLS
>> +       bool "host sunxi-tools"
>> +       help
>> +          Tools to help hacking Allwinner A10 (aka sun4i) based devices and
> Looks like the indentation is wrong (spaces instead of 1 tab + 2 spaces).

Uhm ... I'll check it out ...

>> +         possibly it's successors
>> +
>> +         https://github.com/linux-sunxi/sunxi-tools
>> diff --git a/package/sunxi-tools/sunxi-tools.mk b/package/sunxi-tools/sunxi-tools.mk
>> new file mode 100644
>> index 0000000..60acff5
>> --- /dev/null
>> +++ b/package/sunxi-tools/sunxi-tools.mk
>> @@ -0,0 +1,20 @@
>> +#############################################################
>> +#
>> +# sunxi-tools
>> +#
>> +#############################################################
>> +
>> +SUNXI_TOOLS_VERSION = master
>
> In Buildroot, we usually use commit sha1 instead of branch name;
> otherwise it makes hard to spot what change in a package may have break a build.

You are definitely right.

>> +SUNXI_TOOLS_SITE = git://github.com/linux-sunxi/sunxi-tools.git
>
> BTW, with packages hosted on github, it is possible to just download
> the tarball of the source at a given revision,
> see: http://buildroot.org/downloads/manual/manual.html#github-download-url

Ups ... It seems like I skipped that part.

Thank you for the suggestions ... I will prepare a second submission.

--
Carlo


More information about the buildroot mailing list