[Buildroot] [PATCH] toolchain: check ARM EABI vs. EABIhf for external toolchains
Peter Korsgaard
jacmet at uclibc.org
Wed Jul 17 05:27:42 UTC 2013
>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:
Hi,
>> + else \
>> + echo "Unsupported ABI of the external toolchain" ; \
>> + exit 1 ; \
>> + fi ; \
>> + if [ x$(BR2_ARM_EABI) = x"y" -a $${EXT_TOOLCHAIN_ABI} = "eabihf" ] ; then \
Yann> Using this 'x$(VAR) = xy' construct is ugly. Just quote the variables,
Yann> it is easier to read:
Yann> if [ "$(BR2_ARM_EABI)" = "y" ... ]
Yann> The x$VAR construct was from a time when some shells where failing to
Yann> test against an empty string. That time is long gone. Virtaully all
Yann> shells can compare to empty strings, nowadays.
And we have SHELL=bash
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list