[Buildroot] [RFC 2/3] sunxi-mali: new package

[Thomas Petazzoni]

Dear Spenser Gilliland,

On Tue, 16 Jul 2013 11:46:28 -0500, Spenser Gilliland wrote:

> > It'd be great to have some explanations about what is this
> > sunxi-mali-prop compared to sunxi-mali. At least in the commit log,
> > maybe even somewhere in the source code (but I'm not sure where).
> 
> Basically, sunxi-mali-prop is a git submodule of sunxi-mali.  It is
> copied into the lib/mali directory to emulate this configuration.
> (doesn't work as a symlink unfortunately)

Ok. As discussed on IRC, one option would be to extend the download
infrastructure to be able to pass the --recursive option to Git. Not
sure it's worth the effort for one package though. Maybe what you did
with sunxi-mali + sunxi-mali-prop is the simplest option for now. As I
noted, it should however be documented.

> 
> >> +config BR2_PACKAGE_SUNXI_MALI_PROP
> >> +     bool
> >
> > Maybe you need to select this from sunxi-mali/Config.in ?
> 
> Will fix.

Maybe you can put a small comment above this hidden option, like:

# This option is hidden because this package is merely used as a way of
# downloading a git submodule needed by sunxi-mali. The real package to
# enable is therefore sunxi-mali.

or something along those lines (as a native speaker, I trust you to
find a better english wording than my proposal!).

> > Just curious: there is no kernel modules?
> 
> Well, yes and no.  There is the possibility to build the external
> module.  However, it is included by default in the sunxi-linux kernel.
>  See https://github.com/linux-sunxi/mali-400-kernel-drivers for the
> external module.

Ok. Since those advanced graphics features are anyway only usable with
the sunxi specific kernel at the moment, it doesn't make much sense to
package the external kernel modules.

However, a short comment in the Config.in help text about the need for
those special drivers would be useful.

> > Does this requires a specific Mali X11 driver? Is it something you
> > intend to package in this first version of sunxi-mali, or something you
> > intend to do later (in which case you could remove this choice for now).
> 
> There is an x11 driver here
> https://github.com/linux-sunxi/xf86-video-mali . However, I was
> planning to add this in a later patch series. So, I'll just delete it
> for now.

Yes, sounds good.

> >> +choice
> >> +     prompt "Version"
> >> +     default BR2_PACKAGE_SUNXI_MALI_R3P1
> >> +     help
> >> +       Select the version of the Sunxi Mali binaries to install.
> >> +
> >> +config BR2_PACKAGE_SUNXI_MALI_R2P4
> >> +     bool "r2p4"
> >> +
> >> +config BR2_PACKAGE_SUNXI_MALI_R3P0
> >> +     bool "r3p0"
> >> +
> >> +config BR2_PACKAGE_SUNXI_MALI_R3P1
> >> +     depends on BR2_PACKAGE_SUNXI_MALI_HARDFP
> >> +     bool "r3p1"
> >
> > I wouldn't know how to chose between the three possibilities here, some
> > more help would be nice. Also, maybe add a comment for the r3p1 being
> > not available on !EABIhf systems.
> 
> I'm having trouble finding a description of what cores use which
> version of the libs.  The best method is to install and use the
> maliver application to determine the appropriate version.  I'll add
> info about this to the help text.  Also, I will add the !EABIHF
> comment.

Have you tried asking on the sunxi IRC channel? I'm not on the channel
but I know my colleague Maxime Ripard is there, and it seems to be a
fairly active channel.

> >> +endef
> >> +
> >> +SUNXI_MALI_MAKE_ENV = \
> >> +     CC=$(TARGET_CC) \
> >> +     CFLAGS="$(TARGET_CFLAGS)" \
> >
> > These are generally passed as arguments of make rather than in the
> > environment. It doesn't work in your case?
> 
> No it doesn't.  The makefiles use the CFLAGS variable to add various
> options and setting them as arguments overrides all of this.  When
> placed in the environment, the CFLAGS variable is able to be appended.

Ok. Maybe a short comment above then.

> > Otherwise looks good. Seems like the sunxi-mali stuff is a little bit
> > less horrible than the ti-gfx thing :-)
> 
> A lot less horrible.

Great :)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com