[Buildroot] [PATCH v3] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files

Stefan Fröberg stefan.froberg at petroprogram.com
Wed Jan 30 12:31:15 UTC 2013


29.1.2013 19:50, Arnout Vandecappelle kirjoitti:
> On 29/01/13 08:14, Samuel Martin wrote:
>>> >+                       $(SED) 
>>> "s,^\(exec_\)\?prefix=.*,\1prefix=$(STAGING_DIR)/usr,g" \
>>> >+                               -e "s,-I/usr/,-I\${prefix}/usr/,g" \
>>> >+                               -e
>>> "s,-L/usr/,-L\${exec_prefix}/usr/,g" \
>> Well, just fixing the (exec_)?prefix may not be enough in some case:
>> Some quick grepping in the package directory will show that includedir
>> and libdir should be fixed as well.
>
>  I wouldn't want to do too much in the generic fixup script.
>
>  In fact, the -L substitution is not necessarily correct - some config
> scripts may not define ${exec_prefix}. I'd rather use $(STAGING_DIR)
> explicitly.
>
>  BTW, Stefan: the $ should have been quoted ($$).
>
>  Regards,
>  Arnout
>

So like this ?

-e 's,-I/usr/,-I$$(STAGING_DIR)/usr/,g" \
-e 's,-L/usr/,-L$$(STAGING_DIR)/usr/,g" \



I make one final v4 of that for FOSDEM then and that's that.

Regards
Stefan




More information about the buildroot mailing list